| From: | Alexander Kukushkin <cyberdemn(at)gmail(dot)com> |
|---|---|
| To: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_dump: assert failure sorting casts/transforms |
| Date: | 2026-08-20 11:40:03 |
| Message-ID: | CAFh8B=nowWf0sDk01G7B=sa-TpGTObFEK=NoQMJQLzU_H6af=Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 20 Aug 2026 at 13:04, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
wrote:
>
> One small test-coverage suggestion - the added cast test exercises the
> casttarget tie-breaker, because both casts use the same source type
> and only the target type differs by schema. Since the patch also adds
> a castsource tie-breaker, it may be worth adding a symmetric case
> where two source types share the same typname across schemas and cast
> to the same target type. That would cover both new comparisons
> explicitly.
Thank you for a review Nitin, here is a v2 version of the patch with
extended test coverage.
--
Regards,
--
Alexander Kukushkin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_dump-sort-casts-and-transforms-independent-of-OID-v2.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2026-08-20 11:43:44 | Re: use of SPI by postgresImportForeignStatistics |
| Previous Message | Yilin Zhang | 2026-08-20 11:32:00 | Re: aio: Don't silently drop wait_event_info |