| From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
|---|---|
| To: | Robins Tharakan <tharakan(at)gmail(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Date: | 2017-07-19 18:59:14 |
| Message-ID: | CAFcNs+qinGLqFZ9+QhvdLS+5H1H971NY6dnjrHeGaNRHP+6f2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 19, 2017 at 3:54 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
>
>
> On 18 July 2017 at 23:55, David Fetter <david(at)fetter(dot)org> wrote:
>>
>> Excellent point about pg_dumpall. I'll see what I can draft up in the
>> next day or two and report back.
>
>
>
> Hi David,
>
> You may want to consider this patch (attached) which additionally has the
pg_dumpall changes.
> It would be great if you could help with the tests though, am unsure how
to go about them.
>
You should add the properly sgml docs for this pg_dumpall change also.
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-07-19 19:00:21 | Re: Partition-wise join for join between (declaratively) partitioned tables |
| Previous Message | Tom Lane | 2017-07-19 18:56:31 | Re: Something for the TODO list: deprecating abstime and friends |