From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Failed to request an autovacuum work-item in silence |
Date: | 2018-01-23 11:03:55 |
Message-ID: | CAFcNs+qCaU8zeyNsx56gLLOSczpHCj-WHUHzZC_gogr85ywqiA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Em ter, 23 de jan de 2018 às 03:36, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
escreveu:
> Hi all,
>
> While reading the code, I realized that the requesting an autovacuum
> work-item could fail in silence if work-item array is full. So the
> users cannot realize that work-item is never performed.
> AutoVacuumRequestWork() seems to behave so from the initial
> implementation but is there any reason of such behavior? It seems to
> me that it can be a problem even now that there is only one kind of
> work-item. Attached patch for fixing it.
>
Seems reasonable but maybe you can use the word "worker" instead of "work
item" for report message.
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2018-01-23 11:13:52 | Re: list partition constraint shape |
Previous Message | Константин Евтеев | 2018-01-23 10:45:43 | Invalidation pg catalog cache in trigger functions |