Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: "[pgdg] Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: michael(at)paquier(dot)xyz, noriyoshi(dot)shinoda(at)hpe(dot)com, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module
Date: 2018-08-27 18:53:21
Message-ID: CAFcNs+q-CrcSQPbNPi-SW1ZZLsgeAkkiD264PJ8zSGRzrPanyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 27, 2018 at 3:35 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Aug 27, 2018 at 1:29 AM Michael Paquier <michael(at)paquier(dot)xyz>
wrote:
> > It seems to me that you would pass down just a string which gets
> > allocated for "options", and injection risks are something to be careful
> > about. Another possibility would be an array with comma-separated
> > arguments, say:
> > options = 'option1=foo,option2=bar'
> > There is already some work done with comma-separated arguments for the
> > parameter "extensions", now that's more work.
>
> I like the direction of your thinking, but it seems to me that this
> would cause a problem if you want to set search_path=foo,bar.
>

Maybe we can use multiple "options". Something like:

... OPTIONS ( host 'remhost1', port '5433', dbname 'demodb',
option='option1=foo', option='option2=bar' );

Regards,

--
Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-08-27 18:53:56 Re: More parallel pg_dump bogosities
Previous Message Robert Haas 2018-08-27 18:34:31 Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module