From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: NOT EXIST for PREPARE |
Date: | 2016-03-22 17:44:00 |
Message-ID: | CAFcNs+pFLTNWo+kYC72nF+NB7G=yvEFgts=aOSUXFqgu0=OpSw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 22, 2016 at 2:19 PM, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
wrote:
>
> Yury Zhuravlev wrote:
>>>
>>> You already have a patch? If yes I'm glad to review it.
>>>
>> Please. Patch in attachment.
>
>
> Fix bug, forgot change attr number in parser. And, I forgot example:
> PREPARE usrrptplan (int) IF NOT EXISTS AS
> SELECT * FROM pg_operator;
> PREPARE
>
> New patch in attachment.
>
I'll review it soon... but just a few comments:
1) I think this syntax is wrong... Instead the common should be:
PREPARE [IF NOT EXISTS] ...
2) All of CINE statements we emit a NOTICE skipping message, so you should
emit a message like it:
ereport(NOTICE,
(errcode(ERRCODE_DUPLICATE_PSTATEMENT),
errmsg("prepared statement \"%s\" already exists,
skipping",
stmt->name)));
3) There are no regression tests
4) There are no docs
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2016-03-22 17:57:12 | Re: amcheck (B-Tree integrity checking tool) |
Previous Message | Fabrízio de Royes Mello | 2016-03-22 17:36:43 | Re: NOT EXIST for PREPARE |