Re: pg_dump refactor patch to remove global variables

On Sat, Oct 11, 2014 at 10:15 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
>
> Fabrízio de Royes Mello wrote:
> > On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera <
alvherre(at)2ndquadrant(dot)com>
> > wrote:
> >
> > > Here's the complete patch in case anyone is wondering.
> > >
> > >
> > Hi,
> >
> > Your patch doesn't apply to master:
>
> I think your email system mangled it. I can download it from archives
> and apply it just fine:
>
> $ wget
http://www.postgresql.org/message-id/attachment/35216/pg_dump_refactor_globals.6.diff
-O - | patch -p1
> --2014-10-11 20:44:52--
http://www.postgresql.org/message-id/attachment/35216/pg_dump_refactor_globals.6.diff
> Resolviendo www.postgresql.org (www.postgresql.org)... 87.238.57.232,
174.143.35.230, 217.196.149.50, ...
> Conectando con www.postgresql.org (www.postgresql.org)[87.238.57.232]:80...
conectado.
> Petición HTTP enviada, esperando respuesta... 200 OK
> Longitud: no especificado [text/x-diff]
> Grabando a: “STDOUT”
>
> [ <=> ] 140.127 105K/s en 1,3s
>
> 2014-10-11 20:44:55 (105 KB/s) - escritos a stdout [140127]
>
> patching file src/bin/pg_dump/common.c
> patching file src/bin/pg_dump/dumputils.h
> patching file src/bin/pg_dump/parallel.c
> patching file src/bin/pg_dump/parallel.h
> patching file src/bin/pg_dump/pg_backup.h
> patching file src/bin/pg_dump/pg_backup_archiver.c
> patching file src/bin/pg_dump/pg_backup_archiver.h
> patching file src/bin/pg_dump/pg_backup_custom.c
> patching file src/bin/pg_dump/pg_backup_db.c
> patching file src/bin/pg_dump/pg_backup_db.h
> patching file src/bin/pg_dump/pg_backup_directory.c
> patching file src/bin/pg_dump/pg_backup_null.c
> patching file src/bin/pg_dump/pg_backup_tar.c
> patching file src/bin/pg_dump/pg_dump.c
> patching file src/bin/pg_dump/pg_dump.h
> patching file src/bin/pg_dump/pg_dumpall.c
> patching file src/bin/pg_dump/pg_restore.c
>

Yeah... my gmail mangled the attached file.

Thanks and sorry by the noise.

I'll see the changes.

Regards.

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello