Re: Verbose output of pg_dump not show schema name

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Verbose output of pg_dump not show schema name
Date: 2014-08-26 11:29:21
Message-ID: CAFcNs+oWm7tyaC7U9wbWCEKL+goOJfE+vuL9tZLc6QPMZ7s7Qg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 26, 2014 at 4:10 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> On Tue, Aug 26, 2014 at 3:48 AM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
> > AFAICS, the namespace can never be NULL in any of these. There is a
> > "selectSourceSchema(fout, tbinfo->dobj.namespace->dobj.name)" call
before or
> > after printing the message, so if tbinfo->dobj.namespace is NULL, you'll
> > crash anyway. Please double-check, and remove the dead code if you
agree.
> Ah right, this field is used in many places. Even for
> pg_backup_archiver.c, the portion of code processing data always has
> the namespace set. I am sure that Fabrizio would have done that
> quickly, but as I was on this thread I simplified the patch as
> attached.
>

Thanks Michael... last night I was working on a refactoring in
"tablecmds.c".

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2014-08-26 11:30:38 Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]
Previous Message Oskari Saarenmaa 2014-08-26 11:22:43 Re: Switch pg_basebackup to use -X stream instead of -X fetch by default?