Re: Providing catalog view to pg_hba.conf file - Patch submission

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Prabakaran, Vaishnavi" <vaishnavip(at)fast(dot)au(dot)fujitsu(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: Providing catalog view to pg_hba.conf file - Patch submission
Date: 2015-01-28 19:12:24
Message-ID: CAFcNs+oOYYd5k6oE_YyE=AsW2zR0DwvBdjK2PDLQiip53Y0CiA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 28, 2015 at 4:46 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:
>
> On Wed, Jan 28, 2015 at 9:47 AM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
wrote:
> > On 1/27/15 1:04 AM, Haribabu Kommi wrote:
> >>
> >> Here I attached the latest version of the patch.
> >> I will add this patch to the next commitfest.
> >
> >
> > Apologies if this was covered, but why isn't the IP address an inet
instead
> > of text?
>
> Corrected the address type as inet instead of text. updated patch is
attached.
>
> > Also, what happens if someone reloads the config in the middle of
running
> > the SRF?
>
> hba entries are reloaded only in postmaster process, not in every backend.
> So there shouldn't be any problem with config file reload. Am i
> missing something?
>

I don't have any comment to disagree with the patch (idea and code).

But I'm thinking about this patch and would not be interesting to have a
FDW to manipulate the hba file? Imagine if we are able to manipulate the
HBA file using INSERT/UPDATE/DELETE.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-01-28 19:27:03 Re: Providing catalog view to pg_hba.conf file - Patch submission
Previous Message Tom Lane 2015-01-28 18:52:30 Re: Misaligned BufferDescriptors causing major performance problems on AMD