| From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
|---|---|
| To: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Support for array_remove and array_replace functions |
| Date: | 2012-07-01 19:20:58 |
| Message-ID: | CAFaPBrTo4_qKcFWFg4nTPupAFPdWR_t6e2Jv3RWagi-k-QLziQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jun 30, 2012 at 3:28 PM, Marco Nenciarini
<marco(dot)nenciarini(at)2ndquadrant(dot)it> wrote:
>
> On 30/06/2012 04:16, Alex Hunsaker wrote:
> >
> > Hi, I've been reviewing this patch.
> >
> > Good documentation, and regression tests. The code looked fine but I
> > didn't care for the code duplication between array_replace and
> > array_remove so I merged those into a helper function,
> > array_replace_internal(). Thoughts?
>
> It looks reasonable.
>
> There was a typo in array_replace which was caught by regression tests.
> I've fixed the typo and changed a comment in array_replace_internal.
>
> Patch v3 attached.
Looks good to me, marked ready for commiter.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-07-01 19:59:08 | Re: XX000: enum value 117721 not found in cache for enum enumcrash |
| Previous Message | Hans-Jürgen Schönig | 2012-07-01 19:13:26 | Re: [PATCH] Make pg_basebackup configure and start standby |