Re: alter table only ... drop constraint broken in HEAD

From: Alex Hunsaker <badalex(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: alter table only ... drop constraint broken in HEAD
Date: 2011-10-07 16:45:29
Message-ID: CAFaPBrTE-rn51bi0Mbx1pOuRqX1K5T4k9Keu8PqjMDoeiExdNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 7, 2011 at 09:50, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Oct 7, 2011 at 11:19 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
>> My only thought is
>> perhaps we should add that missing unique index on (conrelid,
>> conname). If we are not going to support duplicate names in the code,
>> we might as well enforce it. No?
>
> Not sure.  There could be performance or other ramifications to that.
> For now I'm more interested in fixing this particular bug than I am in
> getting into a wider world of re-engineering...

Yeah, looking at the code a bit closer we would also want to fix
various places to take advantage of the index. Seems like it could be
a big win when you have thousands of constraints (albeit only in the
add/drop case).

If I find the time maybe Ill submit something along these lines for
the next commit fest.

Thanks!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2011-10-07 16:51:46 Re: Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.
Previous Message Merlin Moncure 2011-10-07 16:34:46 Re: PQsendQuery/ PQgetResult Problem