| From: | Artem Gavrilov <artem(dot)gavrilov(at)percona(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PG19] pg_dump marks extended statistics of pre-v15 partitioned tables as non-inherited |
| Date: | 2026-11-10 14:01:13 |
| Message-ID: | CAFPkQKymArty8kRGUK2ewurOL1MsQwMBzq=3As3ZUk3FRCx0Tg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Corey, Michael,
Thanks for the review!
> It passes tests, but it isn't really exercised by the regular test suite, so we'll have to rely on the buildfarm and even then I'm not sure there will be coverage.
I was unsure how to automate testing for this scenario. I checked
similar patches and didn't find any good examples.
> It is also worth mentioning 269b532aef55 (introduction of stxdinherit
> in pg_statistic_ext_data, affecting v15~), that has removed the
> special path that 20b9fa308ebf (affecting ~v14) has added in
> do_analyze_rel() for partitioned tables.
I added a mention of this to the commit message and also rebased onto
REL_19_STABLE tip (dffcca2e3c8) and verified for master (952bab8b74d).
v2 patch is attached.
--
Artem Gavrilov
Senior Software Engineer, Percona
artem(dot)gavrilov(at)percona(dot)com
percona.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_dump-Fix-inherited-flag-of-extended-stats-from.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-11-10 14:14:15 | Detect mismatched subscription and replication slot properties |
| Previous Message | David Geier | 2026-11-10 13:58:24 | Re: Hash a ScalarArrayOpExpr whose array is fixed for one execution |