| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "jacob(dot)champion(at)enterprisedb(dot)com" <jacob(dot)champion(at)enterprisedb(dot)com> |
| Subject: | Re: pg_createsubscriber does not check output_plugin_libraries |
| Date: | 2026-09-08 04:46:13 |
| Message-ID: | CAFPTHDbtFHdOD5ZmaoVtH_4uk_vbZKiFSG4SjUSp5aYo=dHsCg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 7, 2026 at 3:05 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear hackers,
>
> I found the content was truncated. There might be an environment issue on my side.
> PSA correct ones.
>
A small comment.
in the patch on HEAD, the verb "assume" was correctly used here:
Note that src/bin/pg_upgrade/check.c and
src/bin/pg_basebackup/pg_createsubscriber.c assume GUC_LIST_QUOTE
here.
But in the patch for PG17 and PG18, the verb assumes was incorrectly
used. It should be "assume"
PG17: /* note: src/bin/pg_upgrade/check.c and
src/bin/pg_basebackup/pg_createsubscriber.c assumes GUC_LIST_QUOTE
here */
PG18: /* note: src/bin/pg_upgrade/check.c and
src/bin/pg_basebackup/pg_createsubscriber.c assumes GUC_LIST_QUOTE
here */
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wataru Naotsuka | 2026-09-08 04:49:17 | Authorization semantics and candidate pruning in GRAPH_TABLE |
| Previous Message | Andrey Borodin | 2026-09-08 04:42:59 | Re: Two issues leading to discrepancies in FSM data on the standby server |