| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: logical replication empty transactions |
| Date: | 2021-07-23 05:41:07 |
| Message-ID: | CAFPTHDbRc3vsZRy8JEFjH_4qtdus-V-6AEE8-8T1kWNUAX+s9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 23, 2021 at 10:26 AM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Thu, Jul 22, 2021 at 11:37 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
>
> I have some minor comments on the v9 patch:
>
> (1) Several whitespace warnings on patch application
>
Fixed.
> (2) Suggested patch comment change:
>
> BEFORE:
> The current logical replication behaviour is to send every transaction to
> subscriber even though the transaction is empty (because it does not
> AFTER:
> The current logical replication behaviour is to send every transaction to
> subscriber even though the transaction might be empty (because it does not
>
Changed accordingly.
> (3) Comment needed for added struct defn:
>
> typedef struct PGOutputTxnData
>
Added.
> (4) Improve comment.
>
> Can you add a comma (or add words) in the below sentence, so we know
> how to read it?
>
Updated.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Skip-empty-transactions-for-logical-replication.patch | application/octet-stream | 28.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2021-07-23 05:42:09 | Re: logical replication empty transactions |
| Previous Message | tanghy.fnst@fujitsu.com | 2021-07-23 05:34:26 | RE: [PATCH] support tab-completion for single quote input with equal sign |