| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 024_add_drop_pub.pl might fail due to deadlock |
| Date: | 2025-07-29 09:16:34 |
| Message-ID: | CAFPTHDbKGkcEA5_f3wmTThGaxwG6SjAej-Xg+MeWoHmbgYQ6UA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 29, 2025 at 1:13 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Yes, that makes sense to me. For HEAD and PG18, we can still add a new
> argument to the API. For other bank branches, it is better to use a
> new Ex function as suggested by Kuroda-San.
>
Here are the updated patches.
I have added "Ex functions" for back branches (PG_17 and earlier) ,
which also have Asserts for making sure locks are taken. For PG_18 and
HEAD, I've used the extra parameter already_locked.
PG_14_15-v6-0001-Fix-a-deadlock-during-ALTER-SUBSCRIPTION.-DROP-PU.patch
is for both PG_14 and PG_15 and
PG_18_HEAD-v6-0001-Fix-a-possible-deadlock-during-ALTER-SUBSCRIPTION
is for both PG_18 and HEAD.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| PG_14_15-v6-0001-Fix-a-deadlock-during-ALTER-SUBSCRIPTION.-DROP-PU.patch | application/octet-stream | 5.9 KB |
| PG_16-v6-0001-Fix-a-deadlock-during-ALTER-SUBSCRIPTION.-DROP-PU.patch | application/octet-stream | 5.9 KB |
| PG_18_HEAD-v6-0001-Fix-a-possible-deadlock-during-ALTER-SUBSCRIPTION.patch | application/octet-stream | 6.1 KB |
| PG_17-v6-0001-Fix-a-deadlock-during-ALTER-SUBSCRIPTION.-DROP-PU.patch | application/octet-stream | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | sunil s | 2025-07-29 09:29:35 | Re: Unnecessary delay in streaming replication due to replay lag |
| Previous Message | Stepan Neretin | 2025-07-29 08:56:04 | Making WAL archiving faster — multi-file support and async ideas |