| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Date: | 2020-07-10 05:31:19 |
| Message-ID: | CAFPTHDa_3nEzNUu8WfOttTM8+XS5cT0OnBabN=fGRzT8A0w7iQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2020 at 3:11 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> With your changes sometimes due to incomplete toast
> changes, if it can not pick the largest top txn for streaming it will
> hang forever in the while loop, in that case, it should go for
> spilling.
>
> while (rb->size >= logical_decoding_work_mem * 1024L)
> {
> /*
> * Pick the largest transaction (or subtransaction) and evict it from
> * memory by streaming, if supported. Otherwise, spill to disk.
> */
> if (ReorderBufferCanStream(rb) &&
> (txn = ReorderBufferLargestTopTXN(rb)) != NULL)
>
>
>
Which is this condition (of not picking largest top txn)?
Wouldn't ReorderBufferLargestTopTXN then return a NULL? If not, is there a
way to know that a transaction cannot be streamed, so there can be an exit
condition for the while loop?
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-07-10 05:53:50 | Re: Yet another fast GiST build (typo) |
| Previous Message | Dilip Kumar | 2020-07-10 05:11:19 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |