Re: [PATCH] Preserve replication origin OIDs in pg_upgrade

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Rui Zhao <zhaorui126(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Preserve replication origin OIDs in pg_upgrade
Date: 2026-08-11 02:06:51
Message-ID: CAFPTHDaDx82rAKxSKrOzjwcfurzi+n+fLa9hRyT3R+zjNYZ48A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 30, 2026 at 5:17 PM Rui Zhao <zhaorui126(at)gmail(dot)com> wrote:
>
> Hi Ajin,
>
> The other way to close the gap is to leave the advance alone and count all
> origins in the check instead. That works too, but it makes pg_upgrade ask for a
> max_active_replication_origins the server itself doesn't require -- untracked
> origins are free to create today -- so matching the old cluster's tracking
> looked like the smaller change.
>

Thanks Rui. I have incorporated the changes with some modifications
into the patch.

regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v15-0002-Preserve-replication-origin-OIDs-during-pg_upgra.patch application/octet-stream 38.8 KB
v15-0001-Preserve-subscription-OIDs-during-pg_upgrade.patch application/octet-stream 9.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-08-11 02:27:35 Re: Missing list_free in publicationcmds.c:OpenTableList
Previous Message Quan Zongliang 2026-08-11 02:01:23 Re: [PATCH] Remove stale comment and dead store in BuildTupleHashTable