Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command
Date: 2021-06-04 08:59:35
Message-ID: CAFPTHDZmzsjAE1u+oE5jW7_FrFNOnM3mGDbp3THASpiiSimimQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 4, 2021 at 1:06 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

> I think we can try but not sure if we can get it by then. So, here is
> my suggestion:
> a. remove the change in CreateReplicationSlotCmd
> b. prepare the patches for protocol change and pg_recvlogical. This
> will anyway include the change we removed as part of (a).

Attaching two patches:
1. Removes two-phase from CreateReplicationSlotCmd
2. Adds two-phase option in CREATE_REPLICATION_SLOT command.

I will send a patch to update pg_recvlogical next week.

regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v1-0001-Remove-two-phase-option-from-CreateReplicationSlo.patch application/octet-stream 1.3 KB
v1-0002-Add-option-to-set-two-phase-in-CREATE_REPLICATION.patch application/octet-stream 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-06-04 09:05:17 Re: Skip partition tuple routing with constant partition key
Previous Message tsunakawa.takay@fujitsu.com 2021-06-04 08:59:29 RE: Transactions involving multiple postgres foreign servers, take 2