| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logical replication timeout problem |
| Date: | 2022-03-08 03:53:43 |
| Message-ID: | CAFPTHDZ+1hc060NALXUOkVSGQuqm9FUidiP6wex4-VHeZcP6_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 8, 2022 at 12:25 PM wangw(dot)fnst(at)fujitsu(dot)com
<wangw(dot)fnst(at)fujitsu(dot)com> wrote:
> Attach the new patch.
> 1. Fix wrong variable setting and skip unnecessary time records.[suggestion by Kuroda-San and me.]
> 2. Introduce version information.[suggestion by Peter, Kuroda-San]
>
> Regards,
> Wang wei
Some comments.
1. The comment on top of SendKeepaliveIfNecessary
Try to send a keepalive message if too many changes was skipped.
change to
Try to send a keepalive message if too many changes wer skipped.
2. In pgoutput_change:
+ /* Reset the counter for skipped changes. */
+ SendKeepaliveIfNecessary(ctx, false);
+
This reset is called too early, this function might go on to skip
changes because of the row filter, so this
reset fits better once we know for sure that a change is sent out. You
will also need to send keep alive
when the change is skipped due to the row filter.
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-03-08 04:07:29 | Re: Optionally automatically disable logical replication subscriptions on error |
| Previous Message | Julien Rouhaud | 2022-03-08 03:08:01 | Re: Expose JIT counters/timing in pg_stat_statements |