Re: Support logical replication of DDLs

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Zheng Li <zhengli10(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, rajesh(dot)rs0541(at)gmail(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support logical replication of DDLs
Date: 2022-04-06 11:37:06
Message-ID: CAFPTHDYjRsuehWReLNodspMQbmGc=gs3Ge8PTFur5T+TNC+-5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Wed, Mar 23, 2022 at 4:09 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> On Tue, 22 Mar 2022 at 04:56, Zheng Li <zhengli10(at)gmail(dot)com> wrote:
> > Hi Japin,
> >
> >> You should use a different user that has different length from your current one.
> >> For example:
> >>
> >> px(at)localhost$ make check-world
> >
> > This is fixed in the latest commit:
> > https://github.com/zli236/postgres/commits/ddl_replication
> >
>
> Thanks for fixing this. I rebase the patchset on current master (383f222119)
> and attach here for further review.
>

The patch no longer applies. The patch is a very good attempt, and I
would also like to contribute if required.
I have a few comments but will hold it till a rebased version is available.

regards,
Ajin Cherian
Fujitsu Australia

In response to

Browse pgsql-general by date

  From Date Subject
Next Message David G. Johnston 2022-04-06 12:16:01 Re: Cascade view drop permission checks
Previous Message Thomas, Richard 2022-04-06 10:59:02 PostgreSQL 10.20 crashes / Antivirus

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-04-06 12:04:50 Re: PATCH: add "--config-file=" option to pg_rewind
Previous Message Alvaro Herrera 2022-04-06 11:31:31 Re: shared-memory based stats collector - v70