Re: [PATCH] Preserve replication origin OIDs in pg_upgrade

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Rui Zhao <zhaorui126(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Preserve replication origin OIDs in pg_upgrade
Date: 2026-08-19 05:43:31
Message-ID: CAFPTHDYhw-p7WpMBK1_sDwrZp+EWm+Ae7sncn5gwTtJFYjZUwA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 14, 2026 at 3:29 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Ajin,
>
> Thanks for updating the patch. I think the patch series is mostly good.
> Few cosmetic comments:
>

I have addressed these comments.

On Mon, Aug 17, 2026 at 7:29 PM Rui Zhao <zhaorui126(at)gmail(dot)com> wrote:
>
> Hi Ajin,
>
> v15 applies to master (eb983d0a94), builds warning-free, make check 245/245,
> pg_upgrade TAP 148/148. I also ran a real pg_upgrade with one origin in each
> of the three states -- never advanced, advanced to 0/0, advanced to a real
> LSN -- and all three keep their tracking state:
>
> origin old cluster new cluster
> o_never untracked untracked
> o_tracked_zero 0/00000000 0/00000000
> o_tracked_real 0/12345678 0/12345678
>
> A test gap, a doc paragraph the pre-17 change left behind, and three small
> things.

I have incorporated your comments and your changes in a new patch v16.

regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v16-0001-Preserve-subscription-OIDs-during-pg_upgrade.patch application/octet-stream 9.4 KB
v16-0002-Preserve-replication-origin-OIDs-during-pg_upgra.patch application/octet-stream 40.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-08-19 06:05:51 Re: Fix small psql slash option leaks
Previous Message Michael Paquier 2026-08-19 04:58:01 Re: pgstat: Flush some statistics within running transactions, take 2