| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: logical replication empty transactions |
| Date: | 2021-07-21 11:00:14 |
| Message-ID: | CAFPTHDYHek1O_FNBxcKfp_r2PrknK1GDD1pyRobTL=tDUv5uMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 15, 2021 at 3:50 PM osumi(dot)takamichi(at)fujitsu(dot)com
<osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
> I started to test this patch but will give you some really minor quick feedbacks.
>
> (1) pg_logical_slot_get_binary_changes() params.
>
> Technically, looks better to have proto_version 3 & two_phase option for the function
> to test empty prepare ? I felt proto_version 1 doesn't support 2PC.
> [1] says "The following messages (Begin Prepare, Prepare, Commit Prepared, Rollback Prepared)
> are available since protocol version 3." Then, if the test wants to skip empty *prepares*,
> I suggest to update the proto_version and set two_phase 'on'.
Updated accordingly.
> (2) The following sentences may start with a lowercase letter.
> There are other similar codes for this.
>
> + elog(DEBUG1, "Skipping replication of an empty transaction");
Fixed this.
I've addressed these comments in version 8 of the patch.
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2021-07-21 11:01:11 | Re: CLUSTER on partitioned index |
| Previous Message | Ajin Cherian | 2021-07-21 10:58:45 | Re: logical replication empty transactions |