Re: [PATCH] add concurrent_abort callback for output plugin

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] add concurrent_abort callback for output plugin
Date: 2021-03-30 09:12:57
Message-ID: CAFPTHDY8fPsfisk0iokn_6820MPvfus0Su14RFYzk7zXaLdg0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 30, 2021 at 7:10 PM Markus Wanner <
markus(dot)wanner(at)enterprisedb(dot)com> wrote:

> On 30.03.21 09:39, Ajin Cherian wrote:
> > Where do you suggest this be documented? From an externally visible
> > point of view, I dont see much of a surprise.
>
>
>
> So I suggest to document this as a caveat for the prepare callback,
> because with this patch that's the callback which may be invoked for an
> incomplete transaction without the output plugin knowing.
>

I found some documentation that already was talking about concurrent aborts
and updated that.
Patch attached.

regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v2-0001-Make-sure-a-prepare-is-sent-when-decoder-detects-.patch application/octet-stream 2.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-03-30 09:14:00 Re: Use consistent terminology for tablesync slots.
Previous Message Amit Kapila 2021-03-30 09:02:55 Re: [PATCH] add concurrent_abort callback for output plugin