Re: [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal

Hi,

Please find the attached updated patch with the suggested fixes.

Thanks,
Khushboo

On Mon, Apr 18, 2022 at 2:55 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

>
>
> On Mon, Apr 18, 2022 at 1:56 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Mon, Apr 18, 2022 at 12:47 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Khushboo
>>>
>>> Following are the review comments:
>>> *GUI:*
>>>
>>> - Facing error in the browser. Please check the below screenshot
>>>
>>> [image: 2nd Page.png]
>>>
>> I have left some space above as per the comment given in the demo.
>>
>
> OK, Fix the error shown in the browser.
>
>>
>>> - Unable to test ahead because 'Regions' are not available to select
>>> in the dropdown. Even the code has been verified successfully
>>>
>>> [image: Code.png]. [image: Region_Error.png]
>>>
>> This is working fine for me.
>>
>
> We need to check this as not at all working for me. Am I missing
> something?
>
>>
>>>
>>> *Code:*
>>>
>>> - Jasmine test cases are missing.
>>> - Documentation is missing.
>>>
>>> Documentation is already written and attached with the patch.
>>
>
> OK. After Aditya's commit patch needs to be rebased, fixed other
> review comments, and send again with test cases.
>
>>
>>> - Function comments are not present in the new files. Overall very
>>> less comments about the code. Add comments in rds.py and io.py
>>> - Access token gets printed at the backend, it should not or at
>>> least should be in the Debug log.
>>> - Move BASE_URL = 'https://portal.biganimal.com/api/v1' to
>>> constants.py and remove it from the multiple files.
>>> - Fixed SonarQube issues from the new files and from existing files
>>> if introduced with this patch or previous patch for AWS RDS.
>>> - Update line "help='Amazon AWS RDS PostgreSQL'" in BigAnimal.py.
>>> -
>>>
>>> sid = _create_server({
>>> 'gid': data['db_details']['gid'],
>>> 'name': data['instance_details']['cluster_name'],
>>> 'db': 'edb_admin',
>>> 'username': 'edb_admin',
>>> 'port': 5432,
>>> 'cloud_status': -1
>>> }). Update Why db, username and port are hard coded?
>>>
>>> -
>>>
>>> In "misc/cloud/__init__.py" two function with same name "def get_db_versions()"
>>>
>>> -
>>>
>>> Correct the string "edb_bibanimal_authentication" to "edb_biganimal_authentication" in CloudWizard.jsx and 'VigAnimal Volume Types" to "BigAnimal Volume Types".
>>>
>>>
>>>
>>> On Thu, Apr 14, 2022 at 2:04 PM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch for the implementation of the RM #7179 - PostgreSQL
>>>> deployment on EDB BigAnimal.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>