Re: [pgAdmin4][Patch]: Psycopg3 Fixes

Hi Akshay,

Please find the patch with the fixes.

On Fri, Oct 21, 2022 at 8:58 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> I think you forgot to add the python version check in the requirements.txt
> psycopg2==2.9.*
> psycopg==3.1.0
>
Fixed.

>
> Builds are still failing.
>
> Do we have checks inside the code that if psycopg3 is installed then call
> the API of psycopg3 else fallback to psycopg2? If not then we should add
> such checks.
>

I have put the check in the config file, if the python version is < 3.7
then use psycopg2 otherwise psycopg3.
PEP8 fixes are done.

Thanks,
Khushboo

>
>
> On Fri, Oct 21, 2022 at 8:44 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, the patch applied to the psycopg3 branch
>>
>> On Thu, Oct 20, 2022 at 2:40 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which includes the inclusion of psycopg2
>>> again. So, psycopg2 and psycopg3 both are supported. Also, it fixes some of
>>> the test cases which were failing. The debugger test cases fixes work is
>>> in progress.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>> --
>>
>> <http://www.enterprisedb.com>
>>
>> Akshay Joshi
>>
>> Principal Software Architect
>>
>> +91 9767888246
>>
>> www.enterprisedb.com
>>
>>
>>
>
> --
>
> <http://www.enterprisedb.com>
>
> Akshay Joshi
>
> Principal Software Architect
>
> +91 9767888246
>
> www.enterprisedb.com
>
>
>