Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections

Hi Akshay,

The functionality works properly.

Some minor comments as below:
- Migration file should contain the purpose of the file instead of empty
message string.
- Please remove unwanted imports from the migration file.
- The success message should be 'The saved password cleared successfully.'
or 'Cleared the saved password successfully.'

Thanks,
Khushboo

On Fri, Aug 3, 2018 at 7:16 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> As per discussion I have changed the menu string from "Reset SSH Tunnel
> Password" to "Clear SSH Tunnel Password". Apart from that I have updated
> the documentation also fixed size of some images for the documentation.
>
> Attached is the latest patch. Please review it.
>
> On Wed, Aug 1, 2018 at 2:50 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix RM #3511 Passwords not stored for ssh tunnel
>> connections. Please review it.
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>