| From: | Neha Khatri <nehakhatri5(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Incorrect mention of pg_xlog_switch() in xlogfuncs.c |
| Date: | 2017-05-19 15:08:21 |
| Message-ID: | CAFO0U+9DMg8H1eKBRogfCSvuPFkxzf=P7T7Od+fEFvSczjNuTQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While reading some code, noticed that the headers of functions
pg_walfile_name_offset() and pg_walfile_name() incorrecty refer
pg_xlog_switch() since the inception of code in commit 704ddaaa.
In PG10 implementation, actual name of the referred function is
pg_switch_wal(). So either refer the correct name in the function
header or remove the other function referral from the function header.
Attaching patches for both the ways.
--
Regards,
Neha
| Attachment | Content-Type | Size |
|---|---|---|
| remove_incorrect_function_referral.patch | text/x-patch | 933 bytes |
| correctly_refer_pg_switch_wal.patch | text/x-patch | 927 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-19 15:22:54 | Re: Preliminary results for proposed new pgindent implementation |
| Previous Message | Stephen Frost | 2017-05-19 15:05:26 | Re: Preliminary results for proposed new pgindent implementation |