wal_level > WAL_LEVEL_LOGICAL

From: Neha Khatri <nehakhatri5(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: wal_level > WAL_LEVEL_LOGICAL
Date: 2017-05-22 13:08:56
Message-ID: CAFO0U+83ypUkr-rvYDLf0O1z1=vo=+ef2SbBjbr7SeTv_qogdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

As per my understabding, current postgres server supports only three
values for wal_level i.e. 'minimal' , 'replica' or 'logical'. But
following error message brought to notice that there are various code
spots that try to look for wal_level >= WAL_LEVEL_LOGICAL:

select * from pg_create_logical_replication_slot('regression_slot',
'test_decoding');
ERROR: logical decoding requires wal_level >= logical

The code locations that look for/expect wal_level > WAL_LEVEL_LOGICAL are:

heapam.c 7690 * This is only used in wal_level >=
WAL_LEVEL_LOGICAL, and only for catalog
logical.c 83 errmsg("logical decoding requires wal_level >=
logical")));
standby.c LogStandbySnapshot 950 if (wal_level
>= WAL_LEVEL_LOGICAL)
xlog.h XLogLogicalInfoActive 162 #define
XLogLogicalInfoActive() (wal_level >= WAL_LEVEL_LOGICAL)

Since postgres does not allow wal_level > WAL_LEVEL_LOGICAL, the above
code locations should be modified like:

s/>=/=

Thoughts/Suggestions?

Regards,
Neha

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-05-22 14:36:41 Re: PostgreSQL 10beta1 / OpenBSD : compilation failed with libxml
Previous Message Kuntal Ghosh 2017-05-22 12:34:07 Re: pg_dump ignoring information_schema tables which used in Create Publication.