| From: | Neha Khatri <nehakhatri5(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c] |
| Date: | 2017-05-31 23:59:25 |
| Message-ID: | CAFO0U+-tO1_gfrsOs9BHv8zHZ9dMA2cFEq4e+4Uxe7=aigknrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simplifying $subject. There are typos in xlogfuncs.c. So Either
s/pg_xlog_switch/pg_switch_wal
Or
Remove "pg_xlog_switch" from the comments.
Attached patches both ways.
Regards,
Neha
On Sat, May 20, 2017 at 1:08 AM, Neha Khatri <nehakhatri5(at)gmail(dot)com> wrote:
> While reading some code, noticed that the headers of functions
> pg_walfile_name_offset() and pg_walfile_name() incorrecty refer
> pg_xlog_switch() since the inception of code in commit 704ddaaa.
>
> In PG10 implementation, actual name of the referred function is
> pg_switch_wal(). So either refer the correct name in the function
> header or remove the other function referral from the function header.
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| remove_incorrect_function_referral.patch | application/octet-stream | 933 bytes |
| correctly_refer_pg_switch_wal.patch | application/octet-stream | 927 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-06-01 00:07:16 | Re: [HACKERS] Concurrent ALTER SEQUENCE RESTART Regression |
| Previous Message | Stephen Frost | 2017-05-31 23:59:22 | Re: [JDBC] Channel binding support for SCRAM-SHA-256 |