Re: Making pg_rewind faster

From: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>
To: John H <johnhyvr(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Justin Kwan <justinpkwan(at)outlook(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh ravichandran <admin(at)viggy28(dot)dev>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>
Subject: Re: Making pg_rewind faster
Date: 2025-10-21 04:36:26
Message-ID: CAFC+b6qemJewRKOmCG83cx_wAXvGPFdMqUtEY8cdwnbV_xu73A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi John,

On Tue, Oct 21, 2025 at 3:34 AM John H <johnhyvr(at)gmail(dot)com> wrote:

>
> > 3) maybe we can improve the error messages for the
> > last 2 checks in tap test, that because of this
> > reason hence proven that the copy from source to
> > target has been done.
>
> What are you thinking of? Something like the below?
>
> + "Expected WAL segment $corrupt_wal_seg to have been modified
> due to rewind");
> + "Expected WAL segment $corrupt_wal_seg to have been synced
> from source to target after rewind");
>

maybe something like this
+ "Expected WAL segment $corrupt_wal_seg to have later mtime
on target than source after rewind as it was copied");
+ "Expected WAL segment $corrupt_wal_seg file sizes to be same
between target and source after rewind as it was copied");

--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-10-21 05:04:52 Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array
Previous Message Tom Lane 2025-10-21 04:18:16 Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master