Re: truncating timestamps on arbitrary intervals

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: truncating timestamps on arbitrary intervals
Date: 2021-03-24 18:01:58
Message-ID: CAFBsxsHq9y0vkHjjT2ViOcmUZR6uo1ur+T1me01qOdG8WWHioQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 24, 2021 at 1:25 PM Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>
> 'In cases full units' seems strange.
>
> Not a native speaker but maybe the attached changes are improvements?

- In cases full units (1 minute, 1 hour, etc.), it gives the same result
as
+ In case of full units (1 minute, 1 hour, etc.), it gives the same
result as
the analogous <function>date_trunc</function> call, but the difference
is
that <function>date_bin</function> can truncate to an arbitrary
interval.
</para>

I would say "In the case of"

<para>
- The <parameter>stride</parameter> interval cannot contain units of
month
+ The <parameter>stride</parameter> interval cannot contain units of a
month
or larger.

The original seems fine to me here.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-03-24 18:10:16 Re: Support for NSS as a libpq TLS backend
Previous Message Justin Pryzby 2021-03-24 17:58:15 Re: [HACKERS] Custom compression methods