Re: speed up unicode decomposition and recomposition

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>
Subject: Re: speed up unicode decomposition and recomposition
Date: 2020-10-20 12:03:12
Message-ID: CAFBsxsHcu-ryzGuYjgT==bsJP4u6PCwnZUhSV4PraG_9B2aR7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 20, 2020 at 3:22 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Mon, Oct 19, 2020 at 10:34:33AM -0400, John Naylor wrote:
> > I don't see any difference on gcc/Linux in those two files, nor in
> > unicode_norm_shlib.o -- I do see a difference in unicode_norm_srv.o as
> > expected. Could it depend on the compiler?
>
> Hmm. My guess is that you don't have --enable-debug in your set of
> configure options? It is not unusual to have this one enabled for GCC
> even on production systems, and the size of the libs is impacted in
> this case with your patch.
>

I've confirmed that. How about a new header unicode_norm_hashfunc.h which
would include unicode_norm_table.h at the top. In unicode.c, we can include
one of these depending on frontend or backend.

--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2020-10-20 12:04:06 Re: [doc] improve tableoid description
Previous Message Amit Kapila 2020-10-20 11:12:13 Re: Resetting spilled txn statistics in pg_stat_replication