Re: Statistics updates is delayed when using `commit and chain`

On Fri, Jul 9, 2021 at 7:15 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > /* Send out notify signals and transmit self-notifies */
> > ProcessCompletedNotifies();
> >
> > /*
> > * Also process incoming notifies, if any. This is
mostly to
> > * ensure stable behavior in tests: if any notifies were
> > * received during the just-finished transaction,
they'll be
> > * seen by the client before ReadyForQuery is.
> > */
> > if (notifyInterruptPending)
> > ProcessNotifyInterrupt();

It seems the above would also be skipped in chained transactions -- do we
need to handle notifies as well?

> Attached fixes it by call pgstat_report_stat() when we a in COMMIT AND
CHAIN mode.
> Any thoughts?

Do we need equivalent logic within the TBLOCK_SUBCOMMIT case also? Either
way, a comment is probably in order.

--
John Naylor
EDB: http://www.enterprisedb.com