Re: [PoC] Improve dead tuple storage for lazy vacuum

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum
Date: 2022-12-06 10:32:08
Message-ID: CAFBsxsHNE621mGuPhd7kxaGc22vMkoSu7R4JW9Zan1jjorGy3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 2, 2022 at 11:42 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
wrote:
>
> > On Mon, Nov 14, 2022 at 7:59 PM John Naylor <
john(dot)naylor(at)enterprisedb(dot)com> wrote:
> > >
> > > - Optimize node128 insert.
> >
> > I've attached a rough start at this. The basic idea is borrowed from
our bitmapset nodes, so we can iterate over and operate on word-sized (32-
or 64-bit) types at a time, rather than bytes.
>
> Thanks! I think this is a good idea.
>
> > To make this easier, I've moved some of the lower-level macros and
types from bitmapset.h/.c to pg_bitutils.h. That's probably going to need a
separate email thread to resolve the coding style clash this causes, so
that can be put off for later.

I started a separate thread [1], and 0002 comes from feedback on that.
There is a FIXME about using WORDNUM and BITNUM, at least with that
spelling. I'm putting that off to ease rebasing the rest as v13 -- getting
some CI testing with 0002 seems like a good idea. There are no other
changes yet. Next, I will take a look at templating local vs. shared
memory. I might try basing that on the styles of both v12 and v8, and see
which one works best with templating.

[1]
https://www.postgresql.org/message-id/CAFBsxsFW2JjTo58jtDB%2B3sZhxMx3t-3evew8%3DAcr%2BGGhC%2BkFaA%40mail.gmail.com

--
John Naylor
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v13-0002-Move-some-bitmap-logic-out-of-bitmapset.c.patch text/x-patch 6.1 KB
v13-0004-Use-bitmapword-for-node-125.patch text/x-patch 5.9 KB
v13-0003-Add-radix-implementation.patch text/x-patch 90.8 KB
v13-0001-introduce-vector8_min-and-vector8_highbit_mask.patch text/x-patch 2.6 KB
v13-0005-tool-for-measuring-radix-tree-performance.patch text/x-patch 20.0 KB
v13-0008-PoC-lazy-vacuum-integration.patch text/x-patch 39.8 KB
v13-0007-PoC-DSA-support-for-radix-tree.patch text/x-patch 39.6 KB
v13-0006-Use-rt_node_ptr-to-reference-radix-tree-nodes.patch text/x-patch 57.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-12-06 11:10:32 Re: Time delayed LR (WAS Re: logical replication restrictions)
Previous Message Amit Kapila 2022-12-06 10:28:55 Re: Force streaming every change in logical decoding