| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Small miscellaneus fixes (Part II) |
| Date: | 2023-01-17 07:36:56 |
| Message-ID: | CAFBsxsG9Z4dGO9XiGksYFADBLhY3x6u1Y-UUYWJTJ=RkBYu44g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 16, 2023 at 1:28 PM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
wrote:
>
>
> I wrote:
> > ...but arguably the earlier check is close enough that it's silly to
assert in the "else" branch, and I'd be okay with just nuking those lines.
Another thing that caught my attention is the assumption that unsetting a
bit is so expensive that we have to first check if it's set, so we may as
well remove "IS_BRACKET(Np->Num)" as well.
>
> The attached is what I mean. I'll commit this this week unless there are
objections.
I've pushed this and the cosmetic fix in pg_dump. Those were the only
things I saw that had some interest, so I closed the CF entry.
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-01-17 07:43:44 | Re: Generating code for query jumbling through gen_node_support.pl |
| Previous Message | Richard Guo | 2023-01-17 07:15:37 | Re: Removing redundant grouping columns |