Re: add 'noError' to euc_tw_and_big5.c

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "wangyukun(at)fujitsu(dot)com" <wangyukun(at)fujitsu(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add 'noError' to euc_tw_and_big5.c
Date: 2021-07-21 13:47:31
Message-ID: CAFBsxsFfZ+Zfba=AhjnMwp8jDaUVwdBRvu+RcF-EDRc6jGZZrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 20, 2021 at 10:35 PM Michael Paquier <michael(at)paquier(dot)xyz>
wrote:
>
> On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun(at)fujitsu(dot)com wrote:
> > 'noError' argument was added at commit ea1b99a661,
> > but it seems to be neglected in euc_tw_and_big5.c Line 289.
> > please see the attachment.
>
> That sounds right to me. Double-checking the area, I am not seeing
> another portion of the code to fix.

Pushed, but I forgot to give you review credit, sorry about that. Thanks
for taking a look!

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-07-21 13:54:50 Re: Bitmap reuse
Previous Message David Rowley 2021-07-21 13:45:15 Re: ORDER BY pushdowns seem broken in postgres_fdw