From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
---|---|
To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
Cc: | Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Simple code cleanup in tuplesort.c. |
Date: | 2023-01-05 01:18:39 |
Message-ID: | CAFBsxsF7bRxHKtu65c2sU5zDUaz_DuBNdgJPTq1PNd+z+bEpZw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 16, 2022 at 1:43 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
>
> On Wed, Jul 27, 2022 at 5:10 PM Xing Guo <higuoxing(at)gmail(dot)com> wrote:
>>
>> The bounded heap sorting status flag is set twice in sort_bounded_heap()
and tuplesort_performsort(). This patch helps remove one of them.
>
>
> Revisiting this patch I think maybe it's better to remove the setting of
> Tuplesort status from tuplesort_performsort() for the TSS_BOUNDED case.
> Thus we keep the heap manipulation routines, make_bounded_heap and
> sort_bounded_heap, consistent in that they update their status
> accordingly inside the function.
The label TSS_BUILDRUNS has a similar style and also the following comment,
so I will push this patch with a similar comment added unless someone wants
to make a case for doing otherwise.
* Note that mergeruns sets the correct state->status.
--
John Naylor
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Matthias van de Meent | 2023-01-05 01:21:37 | Re: New strategies for freezing, advancing relfrozenxid early |
Previous Message | Tom Lane | 2023-01-05 01:14:31 | Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler? |