Re: Rework of collation code, extensibility

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Ted Yu <yuzhihong(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Rework of collation code, extensibility
Date: 2022-12-18 04:54:36
Message-ID: CAFBsxsEzR3or=ZYCXOt_cHBmb1YbvZ6S0h5tBBgMNyH90dBZYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 18, 2022 at 10:28 AM Ted Yu <yuzhihong(at)gmail(dot)com> wrote:

> It seems the `else` is not needed (since when the if branch is taken, we
return from the func).

By that same logic, this review comment is not needed, since compiler
vendors don't charge license fees by the number of keywords. ;-)
Joking aside, we don't really have a project style preference for this case.

> nul-terminate -> null-terminate

NUL is a common abbreviation for the zero byte (but not for zero pointers).
See the ascii manpage.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ted Yu 2022-12-18 05:12:00 Re: Rework of collation code, extensibility
Previous Message Ted Yu 2022-12-18 03:27:20 Re: Rework of collation code, extensibility