From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: gcc 13 warnings |
Date: | 2023-03-17 03:14:56 |
Message-ID: | CAFBsxsEyzigJp451jUzssRn1XZxGhUE5XprS59ps7kEA8G14KQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 17, 2023 at 1:11 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2023-03-16 13:54:29 -0400, Tom Lane wrote:
> So I just elected to leave it at the default for meson.
In my build scripts I've been setting it to -O2, because that seemed the
obvious thing to do, and assumed some later commit would get rid of the
need to do it manually. (if it was discussed before, I missed that)
> > I'm not sure if we're prepared to go to -O3 by default though,
> > especially for some of the older buildfarm critters where that
> > might be buggy. (I'd imagine you take a hit in gdb-ability too.)
Newer platforms could be buggy enough. A while back, IIUC gcc moved an
optimization pass from O3 to O2, which resulted in obviously bad code
generation, which I know because of a bug report filed by one Andres Freund:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101481
...which was never properly addressed as far as I know.
I'm a bit surprised we would even consider changing optimization level
based on a build tool default.
--
John Naylor
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2023-03-17 03:19:15 | Re: A problem about ParamPathInfo for an AppendPath |
Previous Message | Richard Guo | 2023-03-17 03:05:03 | Re: Assert failure of the cross-check for nullingrels |