Re: Removing support for COPY FROM STDIN in protocol version 2

On Thu, Feb 4, 2021 at 11:47 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 04/02/2021 17:35, Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> >> Yeah, the changes I was thinking about are all in libpq-int.h so that's
> >> not really a problem. But one enum in libpq-fe.h renumbers values, and
> >> I think it's better to keep the old value labelled as "unused" to avoid
> >> any changes.
> >
> > Oh, yeah, can't do that. libpq-fe.h probably shouldn't change at all;
> > but certainly we can't renumber existing enum values there.
>
> Ah, right, there's even a comment above the enum that says that's a no
> no. But yeah, fixing that, I see no need for .so version bump.

I was able to build libpq and psql on 7.3 with the tooling found on RHEL 7
(the rest of the tree refused to build, but that's not relevant here) and
got the expected message when trying to connect:

master:
Welcome to psql 7.3.21, the PostgreSQL interactive terminal.

patch:
psql: FATAL: unsupported frontend protocol 2.0: server supports 3.0 to 3.0

I couldn't find any traces of version 2 in the tree with the patch applied.
The enum mentioned above seems the only issue that needs to be fixed before
commit.

--
John Naylor
EDB: http://www.enterprisedb.com