Re: Perform COPY FROM encoding conversions in larger chunks

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Perform COPY FROM encoding conversions in larger chunks
Date: 2021-02-09 13:40:02
Message-ID: CAFBsxsE6_Lr+Xk4O+gNWo3aZDRZu=6RsLJ5SoSbTiMQDJxdF9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 7, 2021 at 2:13 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 02/02/2021 23:42, John Naylor wrote:
> >
> > In copyfromparse.c, this is now out of date:
> >
> > * Read the next input line and stash it in line_buf, with conversion
to
> > * server encoding.

This comment for CopyReadLine() is still there. Conversion already happened
by now, so I think this comment is outdated.

Other than that, I think this is ready for commit.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-02-09 13:54:49 Re: adding wait_start column to pg_locks
Previous Message Amit Kapila 2021-02-09 12:56:04 Re: Parallel INSERT (INTO ... SELECT ...)