| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | surya poondla <suryapoondla4(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Fix the race condition for updating slot minimum LSN |
| Date: | 2026-05-15 04:43:25 |
| Message-ID: | CAF0whufH7B+CEnwownzKkCiU4y66oT+trfKT_-777yDq7DrEqQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Hou zj,
I tested the patch on a local debug build.The patch applied cleanly
and postgreSQL built successfully without issues.
I tested logical slot creation,WAL switching,slot advancement,and
checkpoints after applying the patch,and everything worked as expected
without crashes or assertion failures.
I also reviewed the changes in slot.c and slotsync.c .The locking
approach around restart_lsn updates and minimum LSN computation looks
reasonable to me and seems consistent with the existing xmin
synchronization logic.
Surya's explanation regarding copy_replication_slot() also makes sense
to me after reviewing that patch.
Regards,
Solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | solai v | 2026-05-15 04:45:28 | Re: [PATCH] Add pg_get_subscription_ddl() function |
| Previous Message | Fujii Masao | 2026-05-15 04:29:53 | Re: postgres_fdw: use_scram_passthrough on user mapping is ignored when also set on server |