| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | Mario González Troncoso <gonzalemario(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Possible replace of strncpy on xactdesc.c |
| Date: | 2026-07-09 05:03:18 |
| Message-ID: | CAF0whuf52ZnYfaSSn-eexOPWMP4nLiT7=V44S5Rc+kLBtAXduQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Mario,
I tested the patch locally.
Before applying the patch, I verified that strncpy() was used in
ParsePrepareRecord() and tested the affected code path by creating and
committing a prepared transaction using PREPARE TRANSACTION. The
prepared transaction appeared correctly in pg_prepared_xacts, and
COMMIT PREPARED completed successfully.
After applying the patch, I rebuilt PostgreSQL and repeated the same
test. The behavior remained unchanged: PREPARE TRANSACTION, COMMIT
PREPARED, and the committed data all worked as expected.
I didn't notice any regressions during my testing. The change looks good to me.
Thanks for the patch!
Regards
Solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-07-09 05:28:14 | Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats() |
| Previous Message | jihyun bahn | 2026-07-09 04:56:34 | Re: xact_rollback spikes when logical walsender exits |