Re: XMLSerialize: version and explicit XML declaration

On Mon, Aug 3, 2026 at 7:40 PM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
>
> rebase

Hi Jim,

I tested the latest v9 patch on PostgreSQL 20devel.
The patch applied cleanly and the build completed successfully with
libxml support enabled. I also ran the regression tests, and all tests
passed.
I verified the new functionality introduced by the patch:
INCLUDING XMLDECLARATION correctly adds the XML declaration.
EXCLUDING XMLDECLARATION correctly removes the XML declaration.
VERSION '1.0' produces the expected output.
VERSION '1.1' generates the expected warning while still producing valid output.
An invalid version such as VERSION '2.0' correctly raises an error for
DOCUMENT values.
For CONTENT values, VERSION '2.0' is accepted as expected.
I also verified that the existing XMLSERIALIZE behavior remains
unchanged when the new options are not used.

From my testing, the patch works as expected, and I did not observe any issues.

Regards,
solai