Re: [PATCH] Remove unused PageIsPredicateLocked()

Hi all,

On Tue, Sep 22, 2026 at 10:28 AM Aleksander Alekseev
<aleksander(at)tigerdata(dot)com> wrote:
>
> Hi,
>
> The proposed patch removes dead code in src/backend/storage/lmgr/predicate.c
>
> If my understanding is correct, PageIsPredicateLocked() was added in
> dafaa3efb75 (Feb 2011) but its call was removed in 47ad79122bc (Mar
> 2011) and we have never used it since. It was mentioned in one recent
> discussion [1] but it was pointed out that it can't be used there
> either.
>
> If anyone believes that we should keep it alternatively we could cover
> it with tests or at least add an Assert() somewhere.
>
> [1]: http://postgr.es/m/CA%2BCOZaBo%2BZpKgMvxcdACUjNtdYipe9Em06iX5KHLTVaTmFibiw%40mail.gmail.com
>
> --

Thank you for the patch. I tested the patch and verified that the
changes are limited to removing the function implementation and its
declaration. I also find this to be a relevant cleanup and have
confirmed that no references to PageIsPredicateLocked() remain in the
source tree. Then I ran make check-world and git diff --check, which
passed successfully without any issues. There are no functional issues
with the patch and it looks good to me.

Regards,
Solai