| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [DOC] pg_database_size/pg_tablespace_size error on a missing OID |
| Date: | 2026-09-10 05:27:56 |
| Message-ID: | CAF0whueVcXeKhH-BcC6weD5mmOp-1_W5Q-f-JkNHgMDrAMXz3g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I reviewed and tested the v2 patch.
I first verified the existing behavior with a nonexistent OID:
-pg_database_size(999999) returns an error saying the database does not exist.
-pg_tablespace_size(999999) returns an error saying the tablespace
does not exist.
I then applied the v2 patch. It applied cleanly, and git diff --check
reported no issues.
After applying the patch, I repeated the same tests and confirmed that
the behavior remains unchanged. I also tested valid database and
tablespace OIDs, and both returned the expected size values.
From my testing, the patch correctly documents the existing exception
without changing the runtime behavior.
The v2 patch looks good to me.
Thanks,
solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2026-09-10 05:39:13 | Review items for EXCEPT TABLE publication |
| Previous Message | Michael Paquier | 2026-09-10 05:21:50 | Re: pgstat: Flush some statistics within running transactions, take 2 |