| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | cca5507 <cca5507(at)qq(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bug? pg_rewind produces unusable but starting database with standby recovery |
| Date: | 2026-09-08 11:55:17 |
| Message-ID: | CAF0whudnBqjoT4mFzXs9LbJaeZB2ZzHz8g2H4pmg-VBkxhRwsQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
On Tue, Sep 8, 2026 at 5:21 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Thank you both for the review! After reviewing the issue again, I
> agree that my 0002 was wrong.
>
> 0001 received a trivial rebase as there were no conflicts, and I
> simply removed 0002 in favor of ChangAo Chen's thread.
Thank you for the updated patch.
I reviewed and tested the patch. The change in StartupXLOG() looks
correct. The minRecoveryPoint check is now enforced independently of
ArchiveRecoveryRequested, which covers the pg_rewind case where
minRecoveryPoint is set without archive-recovery signal files. The
existing online-backup WAL handling is also preserved. I also verified
the new regression test for the missing source WAL scenario. The test
covers both failure when the required WAL is unavailable and also the
successful recovery when the WAL is available through archive
recovery. Overall, the patch looks correct to me and I did not find
any issues during review and testing.
Regards
Solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajit Awekar | 2026-09-08 12:34:53 | Re: Allow table AMs to define their own reloptions |
| Previous Message | Heikki Linnakangas | 2026-09-08 11:55:11 | Re: Use C11 alignas instead of palloc/malloc for alignment |