| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Antonin Houska <ah(at)cybertec(dot)at> |
| Subject: | Re: REPACK: warn about skipping foreign partitions |
| Date: | 2026-10-14 06:28:39 |
| Message-ID: | CAF0whucvQz_q_+UXABvSTtkBb2uaWYOoX-T31H_=Hh5-Xdc69Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Zsolt,
I tested the v5 patch, “Warn when REPACK or CLUSTER skips a foreign
table,” against the updated PostgreSQL source.
The patch applied successfully, and the build completed without
errors. All regression tests passed.
For manual testing, I created a partitioned table with both a local
partition and a foreign-table partition using 'postgres_fdw'
Before applying the patch, 'CLUSTER' skipped the foreign partition
without displaying a warning.
After applying the patch, I verified that both 'CLUSTER' and 'REPACK'
displayed the expected warnings when skipping the foreign partition.
The local and foreign partition data remained accessible, and both
commands completed successfully in my test case.
The behavior looks good based on these tests. I did not observe any
issues during testing.
Thanks for the patch and the work on this improvement.
Regards
solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-10-14 06:31:22 | Incorrect argument passed to buffer_readv_encode_error() |
| Previous Message | Richard Guo | 2026-10-14 06:06:52 | Re: ERROR: SubPlan found with no parent plan |