| From: | Bryan Green <dbryan(dot)green(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Uninitialized memory access in zic |
| Date: | 2026-05-29 17:19:33 |
| Message-ID: | CAF+pBj_SH=sXYTEA4PU_VpU-ULZez=W_XcmD21BnQ-5YcEvwqQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
So, it looks like the current upstream has removed the QT bug workaround.
It looks to me that the QT bug workaround
was unconditional but the initialization was gated on want_bloat(). I
agree the upstream seems fixed.
bg
On Fri, May 29, 2026 at 11:57 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Valgrind on zic, run during the build, complains about a jump depending
> on
> > uninitialized memory. A cursory check seems to confirm that, but I don't
> > understand the code at all:
>
> That code looks noticeably different in current upstream, so I suspect
> Eggert and crew found and fixed this already. We should probably not
> invest brain cells in tracking it down ourselves, but rather
> prioritize updating our code to some more-recent tzcode version.
> I've been meaning to do that for awhile now, will try to boost it
> to the top of my to-do list.
>
> regards, tom lane
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-05-29 17:25:45 | Re: pg_stash_advice: dump file with overlong stash name crashes worker in a restart loop |
| Previous Message | Tom Lane | 2026-05-29 17:09:03 | Re: alert clients when prepared statements are deallocated |