| From: | albert tan <alterttan1223(at)gmail(dot)com> |
|---|---|
| To: | li carol <carol(dot)li2025(at)outlook(dot)com> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Correct comment wording in extension.c |
| Date: | 2026-01-09 08:58:27 |
| Message-ID: | CAEzort=tx6LsEwY8mpBZ9A9uUa80FZsHcbHzgaX=NSCMeB_tzQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 9, 2026 at 2:17 PM li carol <carol(dot)li2025(at)outlook(dot)com> wrote:
> >On Wed, Jan 7, 2026 at 1:13 PM albert tan <alterttan1223(at)gmail(dot)com>
> wrote:
> >Hi Join,
> >Thanks for pointing out extra issues. I have addressed them in v2.
>
>
>
> Hi Albert, John,
>
>
>
> In addition to the previous findings, I went through
> src/backend/commands/extension.c again and identified other spots that need
> adjustment for better clarity and grammar.
>
> In the header for find_in_paths:
>
> /*
>
> * Work in a very similar way with find_in_path but it receives an already
>
> * parsed List of paths to search the basename and it do not support macro
>
> * replacement or custom error messages (for simplicity).
>
> *
>
> * By "already parsed List of paths" this function expected that paths
> already
>
> * have all macros replaced.
>
> */
>
>
>
> This should be corrected to:
>
> "Works in a very similar way to find_in_path, but it receives an already
> parsed List of paths to search the basename, and it does not support macro
> replacement or custom error messages (for simplicity). By 'already parsed
> List of paths' this function expects that the paths already have all macros
> replaced."
>
>
>
> I hope this helps in making the file more consistent.
>
>
>
> Best regards,
>
> Yuan Li(carol)
>
Hi Carol, John
Thanks for pointing out extra issues. I have addressed them in v3.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Correct-comment-wording-in-extension.c.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-01-09 09:00:47 | Re: [Patch] add new parameter to pg_replication_origin_session_setup |
| Previous Message | Pavel Stehule | 2026-01-09 08:45:45 | Re: proposal: schema variables |