Re: compiler warnings with gcc 4.8 and -Og

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: compiler warnings with gcc 4.8 and -Og
Date: 2022-06-02 14:27:25
Message-ID: CAEze2WiNZ4o9ae14RFe0Tw+VY1fV+7L=kbRTqNSBgP5LKSYijQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2 Jun 2022, 07:10 Tom Lane, <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> > forking: <20220302205058(dot)GJ15744(at)telsasoft(dot)com>: Re: Adding CI to our tree
> > On Wed, Mar 02, 2022 at 02:50:58PM -0600, Justin Pryzby wrote:
> >> BTW (regarding the last patch), I just noticed that -Og optimization can cause
> >> warnings with gcc-4.8.5-39.el7.x86_64.
>
> I'm a little dubious about whether -Og is a case we should pay special
> attention to? Our standard optimization setting for gcc is -O2, and
> once you go away from that there are any number of weird cases that
> may or may not produce warnings. I'm not entirely willing to buy
> the proposition that we must suppress warnings on
> any-random-gcc-version combined with any-random-options.

The "Developer FAQ" page on the wiki suggests that when you develop
with gcc that you use CFLAGS="-ggdb -Og -g3 -fno-omit-frame-pointer"
during development, so I'd hardly call -Og "any random option".

-Matthias

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-06-02 14:33:52 Re: compiler warnings with gcc 4.8 and -Og
Previous Message Robert Haas 2022-06-02 13:51:51 Re: [PATCH] Expose port->authn_id to extensions and triggers